Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the submitter value with name to formData for use:enhance #7012

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Add the submitter value with name to formData for use:enhance #7012

merged 2 commits into from
Sep 24, 2022

Conversation

repsac-by
Copy link
Contributor

@repsac-by repsac-by commented Sep 24, 2022 •
edited
Loading

Fixes #7009

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 7fdfa05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Thank you, looks great! Could you add a changeset by running npx changeset in the monorepo root and then follow the prompts (SvelteKit patch version)? Then we're good to merge 👍

dummdidumm
dummdidumm approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dummdidumm dummdidumm merged commit fdb166c into sveltejs:master Sep 24, 2022
@github-actions github-actions bot mentioned this pull request Sep 24, 2022
Merged
@repsac-by repsac-by deleted the add-submitter-to-formdata branch September 24, 2022 17:56
@philip-weber
Copy link
Contributor

Thank you @repsac-by! That was really quick 👍

@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name and value attributes from buttons in forms are not available in form data when using use:enhance
3 participants
@repsac-by @dummdidumm @philip-weber